Applications: nrf5340_audio: Removed uart terminal #22660
Merged
+5
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
koffes
force-pushed
the
OCT-3390-remove-uart-terminal-from-ncs
branch
from
49c7122 to
52278ce
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 2d88f5a2a89ee6d0ced14d7e56d8b217173f4af9 more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)Outputs:ToolchainVersion: 4aa3467a6d Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: |
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the custom uart_terminal tool from the nRF5340 Audio application, as the functionality is now provided by the VS Code Serial Terminal.
- Updated the release notes to document the removal of the uart_terminal tool.
- Removed the uart_terminal.py file and all associated scripts (open_terminator.py, open_putty.py, linux_terminator_config, get_serial_ports.py).
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst | Added a changelog entry documenting the tool’s removal. |
| applications/nrf5340_audio/tools/uart_terminal/uart_terminal.py | Removed the main uart terminal script. |
| applications/nrf5340_audio/tools/uart_terminal/scripts/open_terminator.py | Removed the linux-specific terminator launcher. |
| applications/nrf5340_audio/tools/uart_terminal/scripts/open_putty.py | Removed the Windows-specific tool launcher. |
| applications/nrf5340_audio/tools/uart_terminal/scripts/linux_terminator_config | Removed the terminator configuration file. |
| applications/nrf5340_audio/tools/uart_terminal/scripts/get_serial_ports.py | Removed the utility script for retrieving serial ports. |
Comments suppressed due to low confidence (1)
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst:221
- Ensure that the naming for the VS Code tool is consistent across all project documentation. Consider verifying that 'nRF Serial Terminal in VS Code' matches the official naming used elsewhere.
* The uart_terminal tool. This was custom for audio and we want to converge on standardized tools. Similar functionality is provided via the nRF Serial Terminal in VS Code.
gWacey
approved these changes
Jun 5, 2025
divipillai
reviewed
Jun 5, 2025
Comment on lines
220
to
221
| * Removed: | ||
| * The uart_terminal tool. This was custom for audio and we want to converge on standardized tools. Similar functionality is provided via the nRF Serial Terminal in VS Code. |
There was a problem hiding this comment.
Suggested change
| * Removed: | |
| * The uart_terminal tool. This was custom for audio and we want to converge on standardized tools. Similar functionality is provided via the nRF Serial Terminal in VS Code. | |
| * Removed: | |
| * The uart_terminal tool to use standardized tools. | |
| Similar functionality is provided through the `nRF Terminal <nRF Terminal documentation_>`_ in the |nRFVSC|. |
Rephrased the sentence. Please check.
alexsven
approved these changes
Jun 12, 2025
koffes
force-pushed
the
OCT-3390-remove-uart-terminal-from-ncs
branch
2 times, most recently
from
01c1d48 to
c0b1187
Compare
OCT-3390 UART terminal removed to align on standard tools. Similar functionality is provided via Serial Terminal in VS Code Signed-off-by: Kristoffer Skøien <kristoffer.skoien@nordicsemi.no>
koffes
force-pushed
the
OCT-3390-remove-uart-terminal-from-ncs
branch
from
c0b1187 to
2d88f5a
Compare
divipillai
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCT-3390
UART terminal tool removed.
Similar functionality is provided via Serial Terminal in VS Code